search

smutch / meraxes

The Meraxes semi-analytic galaxy formation model.
GNU General Public License v3.0
4 stars 6 forks source link

Develop sfr #65

Closed qyx268 closed 2 years ago

qyx268 commented 2 years ago

this PR in principle should be merged into all branches that use the X-ray and Lyman features.

qyx268 commented 2 years ago

@smutch can you take a look at the clang-format check? I dont see a pre-commit yaml file in Meraxes. How can I update the file to match the format requirement?

qyx268 commented 2 years ago

@s-balu before this gets merged, please considered pulling this branch into yours for the current projects.

smutch commented 2 years ago

Sure thing. I’ll try and take a look at that tomorrow…

Cheers, Simon

Dr Simon Mutch Senior Research Data Specialist & STA STEM Ambassador | Melbourne Data Analytics Platform | Petascale Campus Initiative Level 8, Melbourne Connect (Building 290) University of Melbourne, VIC, 3010, Australia T: +61 3 8344 2987 W: http://www.ph.unimelb.edu.au/~smutch/index.html E: @.**@.>

From: Yuxiang Qin @.> Date: Monday, 29 August 2022 at 15:50 To: smutch/meraxes @.> Cc: Simon Mutch @.>, Mention @.> Subject: [EXT] Re: [smutch/meraxes] Develop sfr (PR #65)

https://github.com/smutch

External email: Please exercise caution

@smutch can you take a look at the clang-format check? I dont see a pre-commit yaml file in Meraxes. How can I update the file to match the format requirement?

— Reply to this email directly, view it on GitHubhttps://github.com/smutch/meraxes/pull/65#issuecomment-1229807115, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAF7FCYNSZU2BKZLNA7HGP3V3RFPPANCNFSM574OPN5A. You are receiving this because you were mentioned.Message ID: @.***>

smutch commented 2 years ago

Hey all. I'm so sorry for my tardiness with this. Tomorrow I have marked out an hour to transfer this across to an organisation where @qyx268 can also be a write access reviewer. I'll hopefully send round an email tomorrow with public release plans as well.