feat: Testing and resources

smutel / terraform-provider-netbox

Terraform provider for Netbox

ISC License

58 stars 19 forks source link

feat: Testing and resources #156

Closed amhn closed 1 year ago

amhn commented 1 year ago

fixes #166 This PR is bit on the large side. It depends on #149 and #154. There are a bunch of new resources added, one per commit.

This is done mostly to be able to run the tests on a new docker-netbox container.

If you want I can create PRs per resource, although this would be a bit more work as some of the commits depend on each other (mostly because the tests use resources introduced in earlier commits).

amhn commented 1 year ago

@smutel Did you have time to look at this? Or did you not see it? I just noticed this PR was not assigned to you.

Is this something that could be merged?

smutel commented 1 year ago

Thanks for this PR.

Could you please split this PR in several piece:

This PR should contain only new resources with tests
A new PR for each other file changed

Also please take a look at the pipeline check result.

amhn commented 1 year ago

This branch now only contains new resources (after #164 is merged).

Linter warnings are fixed. I would like to rework all new resources in the style of dcim_site/virtualization_vm before merging. I think this could be ready later today.

amhn commented 1 year ago

All cleaned up and all tests pass you can either merge this PR directly or first merge #164. That PR is included here.