smutt / danish

Experiments with middle-box DANE
GNU General Public License v3.0
6 stars 0 forks source link

Check if TLSClientHello has extensions before checking the extensions #1

Closed smutt closed 7 years ago

smutt commented 7 years ago

Currently in parseClientHello we're not checking if ClientHello has no TLS extensions. So this IF statement can throw an exception and the thread will die.

if 0 not in dict(tlsClientHello.extensions):
  dbgLog(LOG_DEBUG, "SNI not found in TLS ClientHello ip.dst:" + pcapToHexStr(ip.dst))
  return
smutt commented 7 years ago

Fixed