search

sn3p / utstats

Stats for Unreal Tournament 99
Other
13 stars 10 forks source link

fresh start on the UTStats modernization #21

Open elsheepo opened 5 years ago

elsheepo commented 5 years ago
elsheepo commented 5 years ago

I'm very unfamiliar with Git in general, and github even more so. I'm not sure how this whole forking, branches, pull requests thing works, so I'm just gana focus on the code, and if I can't figure out how to do the git thing properly, I'll just redistribute it as best as can as per the LICENCE.

davidbernard04 commented 5 years ago

@elsheepo, by the way there are some guides in github that show really well how to work with github: https://guides.github.com/activities/hello-world/

sn3p commented 5 years ago

@elsheepo thanks for the PR!

I'm very unfamiliar with Git in general, and github even more so. I'm not sure how this whole forking, branches, pull requests thing works

You're doing great so far! Let me know if you have any questions or need help.

Some guidelines and best practices:

  1. Focus on the issue/feature you're working on, e.g. I prefer no changes in the layout (html/css) when you're upgrading PHP/MySQL (different fixes in different PRs).
  2. Create small commits with meaningful chunks of code and commit messages.
  3. I prefer 2 spaces for indenting, not more and no tabs ;)

These are very important because this makes it easier to review and debug.