search

sn3p / utstats

Stats for Unreal Tournament 99
Other
13 stars 10 forks source link

Migrate deprecated mysql to mysqli #8

Open sn3p opened 6 years ago

sn3p commented 6 years ago

Make UTStats work with PHP7.

ThomasVdBerge commented 6 years ago

Whats the status on this one? Would be great finally migrating my webservers :-)

sn3p commented 6 years ago

This should be finished in #9

Think this is done, just need some testing. Help with this is more than welcome!

I've tested locally but some help testing in production would be awesome. Would you mind testing this on your server?

ThomasVdBerge commented 6 years ago

Will do, will keep you posted

ThomasVdBerge commented 6 years ago

Something seems to be off. As soon as I upgrade, I see all my recent matches but when I open one, it only shows the MATCH STATS block. All the others are gone.

This was also the case before the upgrade when I used PHP versions > 5.4

sn3p commented 6 years ago

Thanks for testing @ThomasVdBerge 👍 Let's continue the discussion in #9

elsheepo commented 5 years ago

Also, working on it ;)

sn3p commented 5 years ago

Also, working on it ;)

Awesome! I still have a PR open and ready for this (#9). Maybe you can test this so we can get this merged? Feel free to hijack this PR :)

elsheepo commented 5 years ago

I put about 2 hours into it tonight, this project will be my focus until I get stats running on my php7 server. :cheers:

sn3p commented 5 years ago

I put about 2 hours into it tonight, this project will be my focus until I get stats running on my php7 server. :cheers:

Just saying that PHP7 is working in PR #9, just needs some testing.

elsheepo commented 5 years ago

But honestly, what even the point of using mysqli? I’m rewriting with PDO for sql injection protection. mysqli is already unappreciated.

sn3p commented 5 years ago

Ah didn't know that. Long time since I've used PHP ;)

elsheepo commented 5 years ago

I have some updates to push to this branch if I'm allowed :)

sn3p commented 5 years ago

Probably better to create a new branch. Can you fork and create a PR?

sn3p commented 5 years ago

@elsheepo any progress on your work? Would be nice if we could release it as more and more people are having problems.

sevendays commented 4 years ago

Import.php stops importing after having created the first match and saved in the database. Players are not saved and the script dies there without a message. The log is not moved so subsequent calls fill up the database with the same match over and over.