sn4k3 / UVtools

MSLA/DLP, file analysis, calibration, repair, conversion and manipulation
GNU Affero General Public License v3.0
1.15k stars 103 forks source link

[Bug] Photon Mono M5s Pro incorrect display height and width in PhotonWorkshopFile.cs #858

Closed dbcook closed 3 months ago

dbcook commented 4 months ago

System

Any

Printer and Slicer

Anycubic Photon Mono M5s Pro

Description of the bug

In PhotonWorkshopFile.cs, the display height/width values are wrong. It is not 218x223mm (we could wish!)

See https://wiki.anycubic.com/en/resin-3d-printer/photon-mono-m5s-pro for official values of 223.78 x 126.38

How to reproduce

examine source code

Files

No response

github-actions[bot] commented 4 months ago

This is your first time submitting an issue with UVtools 🥳Please review your issue and ensure that the submit template was followed, the information is complete, and not related to any other open issue. It will be reviewed shortly. Debugging is very important and make the program better. Thanks for contributing and making the software better! 🙌

sn4k3 commented 4 months ago

Will fix on next patch. However that values are never used, they are fetch from file instead, so no potential problem from this bug. Correct values are: 223.6416 x 126.976

sn4k3 commented 3 months ago

Fixed