sn4k3 / UVtools

MSLA/DLP, file analysis, calibration, repair, conversion and manipulation
GNU Affero General Public License v3.0
1.21k stars 104 forks source link

[FEATURE REQUEST] Add sound when done Computing issues #863

Closed sbrevolution5 closed 5 months ago

sbrevolution5 commented 6 months ago

Is your feature request related to a problem?

It can take a long time to run the issue computation/fix, utility, and I usually go and do something else while its running.

Describe the solution you'd like

It would be very convenient if we could have the option to have a chime or ding of some sort play when the issues are finished being detected and fixed. I understand this is such a small concern, but its a potential improvement.

Files

No response

github-actions[bot] commented 6 months ago

This is your first time submitting an issue with UVtools 🥳Please review your issue and ensure that the submit template was followed, the information is complete, and not related to any other open issue. It will be reviewed shortly. Debugging is very important and make the program better. Thanks for contributing and making the software better! 🙌

sn4k3 commented 6 months ago

Cross platform audio engine are heavy and add some dependencies, just to support this is a bit of non-sense. However if it help I can add native notifications, that itself produce a sound from OS if not muted.

Are you on Windows?

sbrevolution5 commented 6 months ago

That would definitley be a solution!  Understandable that implementing a whole audio engine wouldn’t be worth itOn Apr 9, 2024, at 2:23 PM, Tiago Conceição @.***> wrote: Cross platform audio engine are heavy and add some dependencies, just to support this is a bit of non-sense. However if it help I can add native notifications, that itself produce a sound from OS if not muted. Are you on Windows?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

sn4k3 commented 5 months ago

This have to be delayed. Using notifications requires at least Windows 10, version 1809 TFM which will exclude Windows 7 from working with UVtools, I'm not interested in keep two separate builds for windows. Drop the support for Windows 7 is expected when transiting to net8.0 in next major of UVtools (v5).

The solution I came with now is using a spawn of process to write and show the notification, but will only work under windows 10+. That will also allow to produce a beep.

sn4k3 commented 5 months ago

I come to this:

image

Works under Windows & Linux. For mac it will play system invalid beep (No frequency nor duration able)

sn4k3 commented 5 months ago

Implemented