Open gfmio opened 7 years ago
Can I submit these initial fixes as a pull request? Alternatively, can I quickly rewrite the library in TypeScript? That should also solve all problems.
sorry @gfmio somehow I missed your issue completely.
Yes, feel free to submit a PR.
Also a TypeScript rewrite has been on our radar for a long time (you can check old issues). Go ahead if you have the time.
Also, in a complete rewrite scenario, it would be great to consider suggestions and opinions from both the snabbdom and the Cycle.js communities (the @cycle/html module depends on this library). Both projects are written in TS.
Hi! I'm just trying to get
snabbdom-to-html
working with TypeScript and I'm getting a bunch of error messages about the type definitions usingtsc
v2.4.2:The first error can be fixed by replacing the line with
import {VNode} from "snabbdom/vnode";
.The second error can be fixed by replacing the
declare module "snabbdom-to-html"
block withMy linter also alerted me that the declaration of
Module
can be changed toexport type Module = (vnode: VNode, attributes: Map<string, number | string>) => void;
.I couldn't figure out how to get rid off the other error messages (except for by deleting them) unless you move them to separate files.
Can I submit these initial fixes as a pull request? Alternatively, can I quickly rewrite the library in TypeScript? That should also solve all problems.
Cheers!