search

snack-news / Snack-BE

5 stars 3 forks source link

Develop #114

Closed NESOY closed 4 years ago

NESOY commented 4 years ago
jscpd-github-bot[bot] commented 4 years ago

changes to copy/paste analytic.

Orgin copy/paste analytic

Format Files analyzed Total lines Clones found Duplicated lines %
java 44 1328 12 102 7.68
Total 44 1328 12 102 7.68
show detail

Clone found (java): - [src/main/java/com/snack/news/controller/NewsController.java#L1-L6](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/controller/NewsController.java#L1-L6) [src/main/java/com/snack/news/controller/AdminController.java#L1-L6](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/controller/AdminController.java#L1-L6) Clone found (java): - [src/main/java/com/snack/news/controller/TagController.java#L6-L16](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/controller/TagController.java#L6-L16) [src/main/java/com/snack/news/controller/CategoryController.java#L6-L16](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/controller/CategoryController.java#L6-L16) Clone found (java): - [src/main/java/com/snack/news/controller/TopicController.java#L8-L18](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/controller/TopicController.java#L8-L18) [src/main/java/com/snack/news/controller/CategoryController.java#L6-L16](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/controller/CategoryController.java#L6-L16) Clone found (java): - [src/main/java/com/snack/news/service/AdminService.java#L2-L7](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/service/AdminService.java#L2-L7) [src/main/java/com/snack/news/dto/NewsDto.java#L3-L8](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/dto/NewsDto.java#L3-L8) Clone found (java): - [src/main/java/com/snack/news/service/NewsService.java#L1-L8](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/service/NewsService.java#L1-L8) [src/main/java/com/snack/news/service/AdminService.java#L1-L8](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/service/AdminService.java#L1-L8) Clone found (java): - [src/main/java/com/snack/news/service/TopicService.java#L1-L7](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/service/TopicService.java#L1-L7) [src/main/java/com/snack/news/controller/TopicController.java#L1-L7](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/controller/TopicController.java#L1-L7) Clone found (java): - [src/main/java/com/snack/news/service/TopicService.java#L8-L18](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/service/TopicService.java#L8-L18) [src/main/java/com/snack/news/service/TagService.java#L6-L16](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/service/TagService.java#L6-L16) Clone found (java): - [src/main/java/com/snack/news/domain/tag/Tag.java#L2-L16](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/tag/Tag.java#L2-L16) [src/main/java/com/snack/news/domain/category/Category.java#L1-L15](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/category/Category.java#L1-L15) Clone found (java): - [src/main/java/com/snack/news/domain/tag/Tag.java#L25-L35](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/tag/Tag.java#L25-L35) [src/main/java/com/snack/news/domain/category/Category.java#L24-L34](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/category/Category.java#L24-L34) Clone found (java): - [src/main/java/com/snack/news/domain/tag/Tag.java#L38-L47](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/tag/Tag.java#L38-L47) [src/main/java/com/snack/news/domain/category/Category.java#L37-L46](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/category/Category.java#L37-L46) Clone found (java): - [src/main/java/com/snack/news/domain/topic/Topic.java#L1-L10](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/topic/Topic.java#L1-L10) [src/main/java/com/snack/news/domain/category/Category.java#L1-L11](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/category/Category.java#L1-L11) Clone found (java): - [src/main/java/com/snack/news/domain/topic/Topic.java#L35-L42](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/topic/Topic.java#L35-L42) [src/main/java/com/snack/news/domain/category/Category.java#L26-L34](https://github.com/snack-news/Snack-BE/blob/master/src/main/java/com/snack/news/domain/category/Category.java#L26-L34)

New copy/paste analytic

Format Files analyzed Total lines Clones found Duplicated lines %
java 44 1324 11 95 7.18
Total 44 1324 11 95 7.18
show detail

Clone found (java): - [src/main/java/com/snack/news/controller/NewsController.java#L1-L6](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/controller/NewsController.java#L1-L6) [src/main/java/com/snack/news/controller/AdminController.java#L1-L6](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/controller/AdminController.java#L1-L6) Clone found (java): - [src/main/java/com/snack/news/controller/TagController.java#L6-L16](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/controller/TagController.java#L6-L16) [src/main/java/com/snack/news/controller/CategoryController.java#L6-L16](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/controller/CategoryController.java#L6-L16) Clone found (java): - [src/main/java/com/snack/news/controller/TopicController.java#L8-L18](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/controller/TopicController.java#L8-L18) [src/main/java/com/snack/news/controller/CategoryController.java#L6-L16](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/controller/CategoryController.java#L6-L16) Clone found (java): - [src/main/java/com/snack/news/service/AdminService.java#L2-L7](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/service/AdminService.java#L2-L7) [src/main/java/com/snack/news/dto/NewsDto.java#L3-L8](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/dto/NewsDto.java#L3-L8) Clone found (java): - [src/main/java/com/snack/news/service/TopicService.java#L1-L7](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/service/TopicService.java#L1-L7) [src/main/java/com/snack/news/controller/TopicController.java#L1-L7](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/controller/TopicController.java#L1-L7) Clone found (java): - [src/main/java/com/snack/news/service/TopicService.java#L8-L18](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/service/TopicService.java#L8-L18) [src/main/java/com/snack/news/service/TagService.java#L6-L16](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/service/TagService.java#L6-L16) Clone found (java): - [src/main/java/com/snack/news/domain/tag/Tag.java#L2-L16](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/tag/Tag.java#L2-L16) [src/main/java/com/snack/news/domain/category/Category.java#L1-L15](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/category/Category.java#L1-L15) Clone found (java): - [src/main/java/com/snack/news/domain/tag/Tag.java#L25-L35](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/tag/Tag.java#L25-L35) [src/main/java/com/snack/news/domain/category/Category.java#L24-L34](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/category/Category.java#L24-L34) Clone found (java): - [src/main/java/com/snack/news/domain/tag/Tag.java#L38-L47](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/tag/Tag.java#L38-L47) [src/main/java/com/snack/news/domain/category/Category.java#L37-L46](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/category/Category.java#L37-L46) Clone found (java): - [src/main/java/com/snack/news/domain/topic/Topic.java#L1-L10](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/topic/Topic.java#L1-L10) [src/main/java/com/snack/news/domain/category/Category.java#L1-L11](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/category/Category.java#L1-L11) Clone found (java): - [src/main/java/com/snack/news/domain/topic/Topic.java#L35-L42](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/topic/Topic.java#L35-L42) [src/main/java/com/snack/news/domain/category/Category.java#L26-L34](https://github.com/snack-news/Snack-BE/blob/develop/src/main/java/com/snack/news/domain/category/Category.java#L26-L34)

chul-hyun commented 4 years ago

Hey @NESOY,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d22c5120-0378-11ea-bcc9-bf6943779b35
codecov[bot] commented 4 years ago

Codecov Report

Merging #114 into master will increase coverage by 0.29%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #114      +/-   ##
============================================
+ Coverage     65.29%   65.58%   +0.29%     
- Complexity      126      127       +1     
============================================
  Files            39       39              
  Lines           340      340              
  Branches         21       21              
============================================
+ Hits            222      223       +1     
+ Misses          110      109       -1     
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/snack/news/service/NewsService.java 100% <ø> (ø) 3 <0> (ø) :arrow_down:
...s/exception/advice/ControllerExceptionHandler.java 12.5% <100%> (+6.25%) 2 <1> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f6621d...e54d823. Read the comment docs.