jscpd-github-bot[bot]
commented
4 years ago changes to copy/paste analytic.
Orgin copy/paste analytic
| Format | Files analyzed | Total lines | Clones found | Duplicated lines | % |
|---|---|---|---|---|---|
| tsx | 53 | 2717 | 3 | 50 | 1.84 |
| javascript | 38 | 626 | 0 | 0 | 0 |
| typescript | 20 | 904 | 7 | 84 | 9.29 |
| css | 1 | 7 | 0 | 0 | 0 |
| Total | 112 | 4254 | 10 | 134 | 3.15 |
show detail
Clone found (typescript): - [src/api/index.ts#L41-L53](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L41-L53) [src/api/index.ts#L16-L28](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L16-L28) Clone found (typescript): - [src/api/index.ts#L77-L87](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L77-L87) [src/api/index.ts#L64-L74](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L64-L74) Clone found (typescript): - [src/api/index.ts#L93-L106](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L93-L106) [src/api/index.ts#L64-L77](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L64-L77) Clone found (typescript): - [src/api/index.ts#L104-L113](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L104-L113) [src/api/index.ts#L91-L71](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L91-L71) Clone found (typescript): - [src/api/index.ts#L115-L127](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L115-L127) [src/api/index.ts#L103-L115](https://github.com/snack-news/Snack-FE/blob/master/src/api/index.ts#L103-L115) Clone found (typescript): - [src/hooks/useNewsList.ts#L65-L76](https://github.com/snack-news/Snack-FE/blob/master/src/hooks/useNewsList.ts#L65-L76) [src/hooks/useCorpList.ts#L39-L50](https://github.com/snack-news/Snack-FE/blob/master/src/hooks/useCorpList.ts#L39-L50) Clone found (tsx): - [src/layouts/RowListLayout.tsx#L3-L25](https://github.com/snack-news/Snack-FE/blob/master/src/layouts/RowListLayout.tsx#L3-L25) [src/layouts/ColListLayout.tsx#L3-L24](https://github.com/snack-news/Snack-FE/blob/master/src/layouts/ColListLayout.tsx#L3-L24) Clone found (tsx): - [src/layouts/RowListLayout.tsx#L72-L85](https://github.com/snack-news/Snack-FE/blob/master/src/layouts/RowListLayout.tsx#L72-L85) [src/layouts/ColListLayout.tsx#L45-L58](https://github.com/snack-news/Snack-FE/blob/master/src/layouts/ColListLayout.tsx#L45-L58) Clone found (tsx): - [src/layouts/RowListLayout.tsx#L90-L105](https://github.com/snack-news/Snack-FE/blob/master/src/layouts/RowListLayout.tsx#L90-L105) [src/layouts/ColListLayout.tsx#L63-L78](https://github.com/snack-news/Snack-FE/blob/master/src/layouts/ColListLayout.tsx#L63-L78) Clone found (typescript): - [src/services/newsService/api/types.ts#L16-L33](https://github.com/snack-news/Snack-FE/blob/master/src/services/newsService/api/types.ts#L16-L33) [src/hooks/useNewsList.ts#L24-L41](https://github.com/snack-news/Snack-FE/blob/master/src/hooks/useNewsList.ts#L24-L41)
New copy/paste analytic
소스코드 변경 x
server side rendering
빌드 환경 개선
설정 파일들을 간단하고 가독성 좋게 설정 가능하도록 개선
client/babelrc.js
client/src/.eslintrc.js
client/webpack.config.js
server/babelrc.js
server/src/.eslintrc.js
server/webpack.config.js
.eslintrc.js
빌드 환경 개선하면서 수정이 필요해진 개발 환경 도구 임시로 삭제
storybook 제거 (임시)
jest 테스트 환경 제거 (임시)
nps 도구 삭제
path alias 설정 방식 변경 (webpack, tsconfig, jsconfig, babel -> link-module-alias)
여러도구에서 설정해야 됬던 path alias를 1개로 처리 가능한 도구로 개선
기존: 빌드등의 작업시 빌드 도구가 사전에 설정된 path alias를 이용하는 방식
현재: package.json에 _moduleAliases로 설정된 정보를 이용하여 node_modules 디렉토리에 alias 경로로 설정된 디렉토리의 symbolic link 를 추가하여 해결.
이슈:
npm install module_name로 새로운 모듈을 설치할때마다 node_modules에 있는 symbolic link 가 제거되므로npm install명령어를 다시 실행시켜서 symbolic link 를 생성해주어야됨..env 파일을 활용하는 방식으로 개선
utils/env.js
빌드 방식 변경에 따른 배포 코드 수정