snaekobbi / issues

Common issue tracker for the Braille in DAISY Pipeline 2 project
0 stars 0 forks source link

Compare BRF in xprocspec #18

Closed dkager closed 7 years ago

dkager commented 9 years ago

Make it possible to compare BRF files in xprocspec, e.g.:

    <x:context label="brf">
      <x:document type="file" method="text" href="output-dir/file1.brf"/>
    </x:context>
    <x:expect label="brf" type="compare">
      <x:document type="file" method="text" href="../resources/file1.brf"/>
    </x:expect>

The problem is that XML 1.0 doesn't support the Form Feed character entity. You can use the binary method but this makes it difficult to compare the actual result and the expected result. Some ideas:

bertfrees commented 9 years ago

Thanks Davy. I think the last option is a bit similar to something I once proposed: to let custom comparators also implement a custom diff view. This would solve other problems too such as the PEF diff highlighting apparent differences that aren't really differences according to the custom compare step (pef:compare).

josteinaj commented 7 years ago

Moved to: https://github.com/daisy/pipeline-mod-braille/issues/166