CSS property @page:first cause error - Githubissues

snaekobbi / issues

Common issue tracker for the Braille in DAISY Pipeline 2 project

0 stars 0 forks source link

CSS property @page:first cause error #23

Open usama49 opened 8 years ago

usama49 commented 8 years ago

When using CSS property @page:first , it will cause error and no output is produced and pipeline shows success message. For example i used @page:first {margin-left: 2; } in my testing.

bertfrees commented 8 years ago

@page:first is not a braille CSS feature. margin-left: 2 also not in a page context by the way. What exactly is it you want to say with this issue? That the Pipeline should not show a success message when there is an error and no output produced? Or that you want support for @page:first?

usama49 commented 8 years ago

@page:first is mentioned in spec ( 12.1.1 The @page rule) along with page pseudo-classes :left, :right and :blank. It would be nice if you can provide support for @page:first. as @page:left and @page:right is already supported. 2nd thing in general is that Pipeline should not show a success message when there is an error and no output produced. It may provide some kind of information that feature is not supported etc

bertfrees commented 8 years ago

Oh, you're right! Who put that there? :confused: Yes, it will be supported at some point. Do you have a specific use case for it?

For the other thing apparently I already had an issue: see https://github.com/daisy/pipeline-mod-braille/issues/36. Can you see an error message in the log? Or do you just get no output and nothing else?

bertfrees commented 8 years ago

OK I see on the test server that for one job you got the message "Processing terminated by xsl:message at line 426 in css-to-obfl.xsl". I need to find out why this doesn't cause the whole conversion to fail.

usama49 commented 8 years ago

I have plan to use @page:first to treat first page with different CSS style as mentioned by Kari. I received success message and no output as mentioned in issue #36.

bertfrees commented 8 years ago

Can I know the use case? Just to make sure it makes sense before I (or someone else) goes ahead and implement it.

usama49 commented 8 years ago

For example: 1:Each new chapter should start from left page, 2:New volume first page is different from rest of the volume.

i am not sure these can be handled by other approach?

bertfrees commented 8 years ago

Each new chapter start from left page: for that we have page-break-before:left in CSS. However Joel and I decided not to implement this yet (right is implemented but not left) because we didn't have a specific use case and it seemed like a funny thing to do. So is this really how you plan to do it at NLB? Start from left page?
First page of volume different from rest: OK we'll do that with @page:first

usama49 commented 8 years ago

Start from left page? sorry i wrote wrong , we do the same as you mentioned . New chapter starts from "right" page. it means "page-break-before:left" should work.

bertfrees commented 8 years ago

OK good :) Just to be clear:

page-break-before: right mean start from right page. This works.
page-break-before: left means start from left page. This doesn't work (and you don't need it).

usama49 commented 8 years ago

ok. we don't need "page-break-before:left" thanks