Make liblouis-utils/liblouis-mathml build on Windows

snaekobbi / pipeline-mod-braille

ARCHIVED. Please don't make any new issues or pull requests in this repo.

0 stars 0 forks source link

Make liblouis-utils/liblouis-mathml build on Windows #59

Closed dkager closed 8 years ago

dkager commented 8 years ago

Update pipeline-braille-utils/liblouis-utils/liblouis-mathml/pom.xml:

[x] Have the checkout and the script in an optional profile.
[x] daisy#28

bertfrees commented 8 years ago

Either we could convert the bash script into Java, or more simple,
we can make the bash script external (not part of the Maven build) and add the files that are checked out to the source.

Don't like so much your idea of having two counterparts.

bertfrees commented 8 years ago

Or rather have the checkout and the script in an optional profile. This would also make the Maven build independent of SVN/Mercurial (https://github.com/daisy/pipeline-mod-braille/issues/28).

dkager commented 8 years ago

I second this. I’ll look at it.

dkager commented 8 years ago

In 83c3f20. There are still failing tests mucking things up on Windows, but it's a step forward.

bertfrees commented 8 years ago

Some comments:

The profile should only work when activated explicitely with -Pcheckout-tables. Not sure if that's the case now.
The generated files should be checked into git. I will take care of that. The README should also explain how to do this.
Your XML editor messed up the indentation of the bash script so I suggest we move it to an external file to avoid that.

bertfrees commented 8 years ago

Also (detail) the liblouis-mathml doesn't need to be activated because there were no real code changes (except for those warnings you fixed).

dkager commented 8 years ago

Are you saying instead of activating on Unix the profile should be completely manual? In that case just remove the section. I’m still not sure why we don’t just put the tables in main/resources.

(There was a code change: I removed an unused variable. Oh ho ho!)

dkager commented 8 years ago

OK, reopening. I will fix this either today or next week. It's a good way to get to know Maven.

bertfrees commented 8 years ago

I’m still not sure why we don’t just put the tables in main/resources.

Yes that's exactly the plan. I'm going to take care of that. In addition I want to keep the script because it makes moving to a newer version easier.

(There was a code change: I removed an unused variable. Oh ho ho!)

I know... I mean if a module isn't going to be included in the next release it's preferable to have it deactivated so it's not build for no reason. Never mind, not a big deal.

dkager commented 8 years ago

If you keep the script, let's add it in an optional profile as you said, and maybe use this. I tried this locally and while the script obviously doesn't run on Windows the plugin seems to be a lot easier to understand.

bertfrees commented 8 years ago

Fixed by 4cb07d5dd2a35fc0d0da345ad2617168ae30f6ef