search

snaekobbi / requirements

Requirements-based functional testing of the Braille in DAISY Pipeline project
http://snaekobbi.github.io/requirements
0 stars 0 forks source link

Tests for borders #15

Closed bertfrees closed 9 years ago

bertfrees commented 9 years ago

Addresses requirements:

bertfrees commented 9 years ago

@mixa72 Christian thought you could give us some examples of borders. The links in the comment above point to the related requirements. As you can see there is already some data for 4.4:47, which I added just to try out the test suite.

If you don't have the necessary examples or you think these requirements are not important for SBS, just let us know and we'll find someone else to do it. That counts for every requirement/task.

@snaekobbi/experts The reverse is also true of course, if you have a useful example of a certain requirement but you're not assigned to the task, don't hesitate to add it. There's always one assignee per task because that's how Github works and because there has to be a person responsible. But that doesn't mean others can't contribute of course.

bertfrees commented 9 years ago

@mixa72 Do you also have an example for 4.4:50?

mixa72 commented 9 years ago

No, I guess, I do not have such an example. I am not sure, but I think it does not belong to our requirements. Could you assign that to somebody else? Thanks.

bertfrees commented 9 years ago

I was specifically thinking about you when I added that requirement actually :) But maybe I didn't formulate it that well. Isn't this an example? The border below "Kapitel 1" only reaches as far as the text goes.

mixa72 commented 9 years ago

Right!!! And I was really wondering and figuring out exotic use cases while things can be that simple (not even Christian could help me out). So, I'll send you some examples with underlining then :-)

bertfrees commented 9 years ago

@snaekobbi/experts Please have a look at http://snaekobbi.github.io/requirements/borders and let me know if you think something w.r.t. requirements for borders is not clear enough, something is missing, or if you don't agree with a requirement.

dkager commented 9 years ago

Looks good. What sub-requirements are expressed by 47.2 and 47.3? Isn’t the thickness of a border a relative concept, or does the handling of borders change between thin and thick?

bertfrees commented 9 years ago

There's no difference in handling between thin and thick borders, it's just two examples of the same thing. And of course the thickness should be configurable.

bertfrees commented 9 years ago

Mischa's 1st and 4th test for 4.4:47 are still failing because the corners of borders can not have a different pattern. In order to support this, we would need new CSS properties called border-top-left, border-top-right, border-bottom-right and border-bottom-left.

Test 1 is also failing because the top/bottom border can not be shorter than the contents unless the content is a box with a negative left/right margin. But because the source XML is just a simple sidebar this can not be accomplished. Either the sidebar would have to be wrapped by an element in a preprocessing step, or a new ::outside pseudo-element could come to rescue.

Test 4 is also failing because the Dotify based formatter doesn't support the '⠒' pattern for border-top and border-bottom.