search

snaekobbi / requirements

Requirements-based functional testing of the Braille in DAISY Pipeline project
http://snaekobbi.github.io/requirements
0 stars 0 forks source link

Tests for Norwegian translation #6

Closed bertfrees closed 9 years ago

bertfrees commented 9 years ago

Includes:

Addresses requirements:

bertfrees commented 9 years ago

For now I've used the provided XML and PEF files for testing emphasis indicators but I see a possible problem with this kind of test data.

The test case contains not only text with emphasized passages, but also various other features such as text indentation, borders, page numbers. This means we have to do more fidgeting to make the test succeed (see for example the style.css file) and more features of course also make the test brittle, so that it's more likely that we'll have to modify the test data or the test later, which means more work. In general it's better to test more specific features. For example, just a list of input XML snippets vs. expected braille like in http://snaekobbi.github.io/requirements/test/43.1/test.xspec.xhtml#43.1 (no PEFs) would already suffice.

Is more test data coming? Currently we have only one example of strong and one example of em. If you think these examples are representative for all your books (or if you have complete confidence in what liblouis will give us :smile:), that's okay, otherwise I would like to see some more data.

josteinaj commented 9 years ago

I agree, the test data should be as granular as possible.

I think we do have a lot of confidence in liblouis though so if you're ok with this for now then we're ok with this for now.

We haven't got any more data planned at the moment, but I'll look through some old braille documentation and see if there's anything that can be used as test data there.

Maybe it will be easier to create tests after we try out the first test version of the script.

bertfrees commented 9 years ago

Sure, creating tests only when something is wrong with the translation is another approach and I'm okay with that. But I also see these tests as some sort of guarantee that things won't break in the future. Especially for liblouis I think we have to keep in mind things can break because we don't have full control of it but still we want to get table enhancements done by the community (I assume).

bertfrees commented 9 years ago

I referenced the liblouis test (see 4.3:34) and added a test for text-level semantics (see 4.3:38). Do we need something for 4.3:35, 4.3:37 and 4.3:39?

bertfrees commented 9 years ago

There is currently no definition of 8-dot braille. Need to find out whether defining and/or implementing are in scope. If yes, what is the priority.

bertfrees commented 9 years ago

New test data for uncontracted and contracted are available at no_harness.txt, no_harness_g1.txt and no_harness_g1.txt.

bertfrees commented 9 years ago

@usama49 While you are looking at https://github.com/snaekobbi/pipeline-mod-braille/issues/41 you can maybe also have a look at requirement 4.3:39 and check if any tests need to be added for this requirement (could be added to test_translator.xprocspec)