search

snaha-net / diete.design

https://diete.design
MIT License
0 stars 0 forks source link

Remove global `box-sizing` setting in `diete.css` #298

Open vojtechsimetka opened 2 months ago

vojtechsimetka commented 2 months ago

This requires to go through all the components and set the box-sizing to one of the values (and not with * selector which affects snippets including children).

We need to also test (ideally for new components as well) that they don't break if user sets globally box-sizing to either border-box, content-box or inherit.

Related to #296

agazso commented 2 months ago

We need to also test (ideally for new components as well) that they don't break if user sets globally box-sizing to either border-box, content-box or inherit.

Maybe that's too big of an effort to test all this. Instead we can keep the box-sizing: border-box globally in the app.pcss, test with that and document that it works and is tested with that and other settings may cause some components to be broken.

This is still better than the alternative of including just one component and that breaking something unrelated in your existing app.