search

snaha-net / diete.design

https://diete.design
MIT License
0 stars 0 forks source link

feat: date picker #299

Closed hlavkat closed 1 month ago

hlavkat commented 2 months ago

resolve #297

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diete-design ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 1:27pm
agazso commented 2 months ago

Good first version! There are few things we could improve (iteratively in a separate PR):

Indeed, the date picker seems very innocent but there are a lot of small details that makes it difficult to implement well.

* solve displaying the calendar on small screens

I would consider detecting if running on mobile and using a hidden input with type="date" and trigger that so that a native date picker is displayed on mobile.

agazso commented 1 month ago

Works well.

I found a minor issue: when using the keyboard you have to press tab twice so that the focus leaves the text input. This can be addressed in a different PR.