snaha / diete.design

https://diete.design
MIT License
0 stars 0 forks source link

fix: date input default style #264

Closed hlavkat closed 3 months ago

hlavkat commented 3 months ago

resolve #209

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diete-design ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 0:05am
hlavkat commented 3 months ago

I don't really like it, but it's the only way I found to hide the icon in firefox @agazso

agazso commented 3 months ago

I don't really like it, but it's the only way I found to hide the icon in firefox @agazso

My issue is that nothing happens when I click on the date icon. Tested in Chrome and Firefox.

hlavkat commented 3 months ago

I don't really like it, but it's the only way I found to hide the icon in firefox @agazso

My issue is that nothing happens when I click on the date icon. Tested in Chrome and Firefox.

Yes, clicking on the added button will not show anything, because the separate calendar has not yet been implemented. I just wanted to hide the default icon

agazso commented 3 months ago

Yes, clicking on the added button will not show anything, because the separate calendar has not yet been implemented. I just wanted to hide the default icon

I see but this breaks existing functionality, because you can no longer use a date picker, whereas previously at least there was a date picker with the default style. I think it is better to not have features than having half-working ones. In this case I would consider not supporting date input at all.

hlavkat commented 3 months ago

I see but this breaks existing functionality, because you can no longer use a date picker, whereas previously at least there was a date picker with the default style. I think it is better to not have features than having half-working ones. In this case I would consider not supporting date input at all.

I understand, well in that case I delete the label for now right?