search

snaha / diete.design

https://diete.design
MIT License
0 stars 0 forks source link

feat: horizontal rule component #270

Closed hlavkat closed 3 months ago

hlavkat commented 3 months ago

resolve #229

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diete-design ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 7:56am
agazso commented 3 months ago

After checking out the (almost empty) component page I had second thoughts about this. Maybe it would better to keep it as a CSS-only component (which we did not have so far). @vojtechsimetka wdyt?

agazso commented 3 months ago

I kinda agree with you @agazso but I am not all that sure how we would present this in docs. Instead, I would suggest that this gets renamed to Divider and it has both horizontal and vertical orientation. This is quite common component in UIs https://nextui.org/docs/components/divider

All right, let's call it Divider and have an additional orientation: 'horizontal' | 'vertical' property which is by default horizontal.