Judges' feedback

[ghost]

Placeholder issue for judges' feedback.

[railschallenge-judge01]

Routes

• Considering using except rather than only - the list will be shorter

Migrations

• Consider db-level null validations for additional data integrity

Application Helper

• Is functionally empty - don't really need it

Models

• Responder
  • capacity_summary - map is a great functional method that helps prevent mutable state, however, you are mutating the data hash within it. Better to just change this map to an each() method, as that's how you're using it
• Emergency - you can reduce some code duplication by combining your validation lines:

  validates :fire_severity, :police_severity, :medical_severity,
            presence: true, numericality: { only_integer: true, greater_than_or_equal_to: 0 }

• before/after filters can lead to difficult-to-trace code and convoluted workflows
  • An alternative would be to have a business object/PORO that manages he emergency save and dispatch combined workflow
• responders_names - could be rewritten as responders.select('name').pluck(:name)
• dispatch_responders - the to_a call is ok here, but wouldn't scale in a real-world case with many responders

Controllers

• You don't need the skeleton action comment headers - the action names are sufficient to explain their intent
• New and Edit actions don't need to be defined - there are no routes them
• You don't need format: :html calls for this solution

[ghost]

Verified score of 114 points on the automated scoring, based on the current master branch.

[ghost]

Your score breakdown (you placed 15th):

204 points total (only 2.5 points behind the person in 14th):

• 114 points for passing tests
• 90 points for judge's section