snakemake-workflows / rna-seq-kallisto-sleuth

A Snakemake workflow for differential expression analysis of RNA-seq data with Kallisto and Sleuth.
MIT License
66 stars 44 forks source link

any name for diffexp grouping column, fix no custom_transcripts, future-proof column select() #13

Closed dlaehnemann closed 4 years ago

dlaehnemann commented 4 years ago

The main point of this PR is to remove the schema-requirement of a sample.tsv sheet column named condition. Usually, it makes more sense to specify a more informative name for that column (e.g. something like group1_vs_group2), which will also be picked up in labeling etc. This also requires removing the condition column from the respective select(), but the custom-named column will be picked up through the formula, anyways.

As a side-effect, this PR future-proofs the column select() on a vector of strings with the all_of() function and fixes a bug that occurs, if the provided transcriptome does NOT contain any custom transcripts -- i.e. we now handle this case properly.