search

snakemake-workflows / rna-seq-kallisto-sleuth

A Snakemake workflow for differential expression analysis of RNA-seq data with Kallisto and Sleuth.
MIT License
64 stars 43 forks source link

perf: bump datavzrd wrapper to 2.6.0 and general bug fixes #79

Closed manuelphilip closed 1 year ago

manuelphilip commented 1 year ago

Hi @dlaehnemann , I am confused about where and how to find <commit-hash-1> properly. Can you please assist me with the exact location to get this <commit-hash-1>?

dlaehnemann commented 1 year ago

You can either find those right here on GitHub, by clicking on a particular commit. So I for example expect that the commit perf bump datavzrd wrapper to 2.6.0 and general bug fixes is one that belongs into this pull request. You can simply click on its link above, and then you should see the changes it introduces on a separate page. There, at the top right, you'll find commit bd964f73ab69487921766290faf9674958ae1c58. The letters and numbers are the commit's hash value.

Alternatively, you can find the commits locally on any machine where you have the repository cloned and the branch 3-prime-rna checked out. You can then issue git log on the command line and will get a browsable list of all the commits. And each commit again start with an entry of something like commit bd964f73ab69487921766290faf9674958ae1c58.

So you just go through the list of commits here, and find all the hashes like bd964f73ab69487921766290faf9674958ae1c58 for the commits that really introduce the changes of this pull request. And in the future, it is usually a good idea to start a new branch for any new pull request, especially if the original branch (like the 3-prime-rna branch here) has already been merged. This keeps the commit history and pull requests much cleaner.

manuelphilip commented 1 year ago

I understand it now. Thank you @dlaehnemann for the detailed explanation. It really helped. I have created a new pull request with the latest changes mentioned here. Shall I remove this pull request as this might create confusion with the new one that I created?

dlaehnemann commented 1 year ago

With the new pull request, we can cross-reference this pull request here. So this should be pull request #80 , right? With this mention, this old pull request over here gets mentioned in the new one, as well.

And as you probably don't need this branch here, any more, but will instead create new branches off of the main branch for any future changes, you could go and Delete branch. You will still have the branch locally, where you developed it, but the repository here will stay cleaner and saner.

manuelphilip commented 1 year ago

Noted it.