search

snakemake-workflows / rna-seq-kallisto-sleuth

A Snakemake workflow for differential expression analysis of RNA-seq data with Kallisto and Sleuth.
MIT License
64 stars 43 forks source link

perf: bump datavzrd wrapper to 2.6.0 and general bug fixes #80

Closed manuelphilip closed 1 year ago

manuelphilip commented 1 year ago

Created a new and separate pull request previously was merged with 3-prime-rna branch

dlaehnemann commented 1 year ago

Also, I added another pull request, namely to:

  1. Make release please happy. It previously gave this error about the commit message of the only commit: 
    Error: Pull request has only one commit and it's not semantic; this may lead to a non-semantic commit in the base branch (see https://github.community/t/how-to-change-the-default-squash-merge-commit-message/1155). Amend the commit message to match the pull request title, or add another commit.
    1. Also make the formatting step of the CI happy. So generally, running snakefmt workflow/ on a branch when creating a pull request makes sense, as otherwise the formatting step will very often complain.
manuelphilip commented 1 year ago

Yeah, Actually I was searching for this error message that came previously. Can you point me to the change that you made to resolve this error?

Yea, I have the extension installed in my vscode for snakefmt format. But forgot to run it before pushing :(

dlaehnemann commented 1 year ago

Just click on the commit snakefmt, which is listed above my last comment. So all I did was run snakefmt workflow/ locally, commit it via git to this branch and push it here.