Fix for GitHub Actions, and fix to avoid potential column reordering in count-matrix.py

snakemake-workflows / rna-seq-star-deseq2

RNA-seq workflow using STAR and DESeq2

MIT License

327 stars 203 forks source link

Fix for GitHub Actions, and fix to avoid potential column reordering in count-matrix.py #49

Closed cbp44 closed 1 year ago

cbp44 commented 2 years ago

Another shot at trying to get GitHub Actions working. The tests pass on my master branch as shown here.
Fix for issue #32.

An analysis can fail if the count-matrix.py script inconsistently sorts output columns. The default behavior of the pandas.matrix.groupby function is to sort the grouping keys, but the sorting is not stable and causes the workflow to fail sometimes in the deseq2_init rule of the analysis if the sorting happened to change the order.

I ran into this bug a while ago and it prevented analyses where I had dozens of units in the units.tsv file that spanned sequencing lanes.

cbp44 commented 2 years ago

@johanneskoester Can you please approve the workflow so the test can run? It is strange that the tests work on my fork, but not here, and I would like to help fix the GitHub Actions for you.

I have a lot of additional bug fixes and enhancements that I would like to try and get merged here too, but that can't happen without GitHub Actions working first.

dlaehnemann commented 1 year ago

Hey @cbp44! Thanks for your contribution here and sorry for not picking this up earlier. Feel free to ping us about such things on the Discord server for snakemake: https://discord.gg/NUdMtmr

Regarding your suggestions here, I integrated the updates to the GitHub Workflow with PR #59, that also updates all wrappers and all conda environments. As this PR comes from your master branch, I would have to modify that to rebase this PR onto the latest master branch here, but didn't want to mess with your stuff.

But as we have passing CI tests again, would you be willing to rebase this fix (and the others you were mentioning) onto the latest master branch?

cbp44 commented 1 year ago

@dlaehnemann Can do.

I just rebased the master branch onto my fix/count-matrix-groupby branch containing only the count-matrix.py change that I made.

I opened a new pull request to get that branch merged in (PR #60).