snakemake-workflows / rna-seq-star-deseq2

RNA-seq workflow using STAR and DESeq2
MIT License
327 stars 203 forks source link

feat!: generalize away condition #66

Closed dlaehnemann closed 1 year ago

dlaehnemann commented 1 year ago

This pull request mainly generalizes the configuration of DESeq2 differential expression analysis in a way that closes #53. Every use of condition (except for one very basic test case) is changed to variable_of_interest in general settings and to specific variable names wherever something is configured for a particular analysis. The aim is to always be explicit about configuration, as opposed to relying on defaults in DESeq2 (which I find confusing at times).

The new setup allows for:

In addition, I fixed some other things in this pull request, as this will mean a major version bump, anyways:

johanneskoester commented 1 year ago

Very nice work!

jonathandmoore commented 1 year ago

Thanks for inviting review, looks like I missed the merge, but great to see the improvement.