mbhall88 commented 2 years ago

I have been testing dev for a little while now so I think it's ready. Happy to wait a little longer though if we want further testing?

codecov[bot] commented 2 years ago

Codecov Report

Merging #146 (a942653) into master (d233dfa) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   98.20%   98.25%   +0.04%     
==========================================
  Files          12       12              
  Lines         949      973      +24     
  Branches      211      216       +5     
==========================================
+ Hits          932      956      +24     
  Misses         10       10              
  Partials        7        7

Flag	Coverage Δ
unittests	`98.15% <100.00%> (+0.04%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
snakefmt/parser/grammar.py	`100.00% <ø> (ø)`
snakefmt/parser/parser.py	`96.39% <ø> (ø)`
snakefmt/formatter.py	`100.00% <100.00%> (ø)`
snakefmt/parser/syntax.py	`99.05% <100.00%> (ø)`
snakefmt/snakefmt.py	`95.89% <100.00%> (ø)`

bricoletc commented 2 years ago

Looks great. One thing is we should aim to include external contributions: here @maarten-k 's support for retries. to do this in general i think we rebase the contributor's PR onto your PR, or ask the contributor to push that commit to the PR branch. perhaps adding a thanks in the CHANGELOG would be enough this time round

Otherwise, let's merge/release!

mbhall88 commented 2 years ago

Hmmm, I just tagged the release, but realised the release workflow was changed by @johanneskoester. I don't know how to trigger a new pypi release now...

snakemake / snakefmt

chore: Prepare for release of 0.6.1 #146

Codecov Report