snakemake / snakefmt

The uncompromising Snakemake code formatter
MIT License
153 stars 29 forks source link

Importlib_metadata pinned at very old version #162

Closed corneliusroemer closed 1 year ago

corneliusroemer commented 1 year ago

I've noticed that importlib_metadata is pinned at version 1.* when version 2 came out already a 2 years ago

Would it make sense to update this pint or make it less strict?

https://importlib-metadata.readthedocs.io/en/latest/history.html

image

https://github.com/bioconda/bioconda-recipes/blob/dab3e65f7a3073d0abe3ecf22f249a36b21bfac7/recipes/snakefmt/meta.yaml#L31

https://github.com/snakemake/snakefmt/blob/f136a7ec300310862e501823604f04bffa519c4c/pyproject.toml#L21

jbloom commented 1 year ago

I was just having problems with this same point. It is starting to make it hard to install snakefmt in pipelines with new versions of other software.

corneliusroemer commented 1 year ago

@jbloom I guess the workaround is to install it in a separate conda environment and make a soft-link or something like that:

mamba create -n snakefmt  
conda activate snakefmt
mamba install -y snakefmt

Then snakefmt can be called like: /opt/homebrew/Caskroom/miniforge/base/envs/snakefmt/bin/snakefmt in my case (find out your local path via which snakefmt)

bricoletc commented 1 year ago

Will have a look at this in the next 7 days :+1: