search

snakemake / snakefmt

The uncompromising Snakemake code formatter
MIT License
147 stars 28 forks source link

feat: update to black v24 and fix double curly braces (Updated PR #216) #219

Closed bricoletc closed 7 months ago

bricoletc commented 7 months ago

Ok, I mistakenly closed #216, here's #216 + my two commits

@mbhall88 can you please respond to my comments on #216 and see if you're happy with my two added commits?

We can then keep updating this branch here.

Brice

mbhall88 commented 7 months ago

All looks good to me. Good idea on refactoring the { addition.

As for merging from snakefmt branches, sure we can do that. I do prefer from my own fork though just in case I try and push to master, which wouldn't matter on my fork. There is an option to allow you to push to my PRs - it's a checkbox in the right panel of the PR below the "Lock conversation" section. If you select that it allows maintainers of snakefmt to push to the PR. Maybe we can just try and remember to check that. Anyway, I don't mind either way.

bricoletc commented 7 months ago

Oh, being able to push to our respective forks is much better, as you say it protects us from mistakenly pushing to master here. Will have a look for that checkbox next time round (can't see it on the PR right now, though)