snakemake / snakemake-executor-plugin-slurm

A Snakemake executor plugin for submitting jobs to a SLURM cluster
MIT License
18 stars 19 forks source link

Select partition automatically #106

Open SilasK opened 5 months ago

SilasK commented 5 months ago

Hello, I would like to that the wrapper can select the partition automatically based on the resources.

I implemented something in https://github.com/Snakemake-Profiles/generic

It loads a csv table and selects the appropriate profile. Do you think something like this could be implemented?

cmeesters commented 5 months ago

Hi,

Sounds like an interesting consideration. However, the shown link does not show such a selector - or does it?

Please consider: The design of this plugin has an emphasis on stability. Introducing some sort of heuristic would inexplicitly lead to failures here or there.

SilasK commented 5 months ago

My script is located here: GitHub.

I agree it is a bit heuristic, but one should be able to get the Slurm partitions with sinfo or similar commands.

Currently, if I submit a high-memory job/rule to Slurm via this tool, it is submitted to the default queue and is never scheduled because the default queue doesn't allow high-memory jobs.

I can define queues in Snakemake for my cluster, but how can I ensure that it will also work on another HPC?

SilasK commented 5 months ago

BTW, your plugin is awesome and stable!

cmeesters commented 5 months ago

Stupid me! I missed the crucial part in your code.

Now, currently Snakemake users have three points to configure their specs: The command line, the workflow itself or a workflow profile. We recommend not using the workflow files because all workflows should be kept portable.

Within the profiles, we can define defaults and deviating resource specs per rule (see here). Would we offer a csv/tsv file with partition specs in addition, users could skip the partition selection in their profiles, as the resources still need to be defined. This would display a minor gain at the cost of needing an additional config file. Do I get this right?

This configuration scheme, while flexible, is only fine, with a few rules requiring more or different resources than in our default. So, I too would very much prefer some automatism because resource definitions can get quite cumbersome. With sinfo we can get all the partitions, parsing scontrol partition <name> would give us additional specs. We could code that these commands get executed, the information saved and - using educated guesses - implement some sort of automated selection. It would be a major endeavour, but really nice to have. Alas, we would not know additional interface flags, admins can code with so-called "spank plugins" or any other plugin they provide to their site-specific SLURM setup. We also would have a hard time figuring out a user's specific needs (AI code and multi-node (MPI) jobs need to be accounted for, too) and have to cover every corner case (installed additional plugins which might influence scalability, etc. etc.).

Read this as a confession: I am overwhelmed by the potential points of failure and don't dare to attempt to implement this. However, I have some small ideas for improvement and hope to get a project on track in the not-so-near-future. If you would meanwhile submit a PR, we would be happy to consider it - even if we cannot merge it into the production line for a while.

dlaehnemann commented 5 months ago

I'll start with some general thoughts on if and how to select the partition / queue automatically. This is mostly from experience with using an LSF cluster system, but I think this generalizes. Cluster systems can always be configured heavily, and oftentimes it is not straightforward to determine configurations. So with queues / partitions with arbitrary names and all kinds of possible resource limitations and requirements, I think this is not something easily automatable via the resprective executor plugin. So I think I would first go for optimizing things via profiles, and think more about generalizing such things, once we all have more experience with dynamic queue / partition allocations...

And then I'll just cross-post my resprective thoughts on profiles from this Discord discussion, to keep this documented here:

As these kinds of specs are usually very specific to your local cluster setup, I think using profiles is a good idea: https://snakemake.readthedocs.io/en/stable/executing/cli.html#profiles

Depending on the level of control you have and how generically it should be used, you can put a profile in three different locations:

  1. profiles/default/config.yaml in the workflow that you are running (also works if the workflow is deployed via a module import). This will keep all settings restricted to that workflow instance.
  2. $HOME/.config/snakemake/default/config.yaml will apply the settings to all of the workflow instances of you as a user. So if you have deployed the same workflow multiple times, all will benefit from changes here. But this already requires making the settings as dynamic as possible, as different datasets can lead to completely different resource requirements...
  3. /etc/xdg/snakemake/default/config.yaml will apply these settings system-wide for all users. This only works if you have admin rights, but can significantly improve the ease of deployment of workflows over a larger number of users.

Note: if you put the config.yaml file in a folder different from default/, you'll have to provide that profile name to the --profile or --workflow-profile command-line argument.

I now regularly use user-specific profiles, to for example set the queue depending on the input file size, mostly on an LSF cluster system. So the config.yaml file will contain something like this:

set-resources:
  lsf_queue: '( "verybig" if input.size_mb > 100000 else "big" )'

Note the parentheses around the expression. These are needed, so that snakemake properly evaluates the expression in the right step.

cmeesters commented 5 months ago

Thank you, David! Though, any user of a complex workflow still needs to come up with a profile. What you wrote stresses the need to update the docs (a bit), rather than implying code changes. Auto-parameterization for clusters remains a dream ;-).

dlaehnemann commented 5 months ago

Yeah, I'm definitely for cleaning up and improving the docs a bit regarding profiles and dynamic resource settings. Learned a lot through trial-and-error in the past weeks and months, and this was always on the list to do at some point. So maybe that point is now...

SilasK commented 5 months ago

Would it be possible to select the queue by resources.mem_mb argument dynamically?

SilasK commented 5 months ago

Is there a way to make a quite complicated if else statement using multiple criteria?

cmeesters commented 5 months ago

Would it be possible to select the queue by resources.mem_mb argument dynamically?

Like I wrote, implementing such a feature should not stop there. This is not done easily for a submit plugin.

Is there a way to make a quite complicated if else statement using multiple criteria?

Absolutely, this is just Python code.

@dlaehnemann wouldn't is be a nice feature to be able to point --workflow-profile to a specific file, too? Then we could collect profile templates in repos reading something like config_<cluster site>_<cluster name>_<date/version>.yaml. And thereby save re-inventing the wheel a bit.

dlaehnemann commented 5 months ago

Is there a way to make a quite complicated if else statement using multiple criteria?

Yes, you can basically chain things with the syntax I gave above. Or test other kinds of syntax. From my understanding, the only limitation is that it has to be a one-liner. But that is really flexible in Python...

Would it be possible to select the queue by resources.mem_mb argument dynamically?

The signature for the callable that you can use in dynamic resource allocation currently is:

callable(wildcards [, input] [, threads] [, attempt])

So resources is not available, but you can for example make anything dependent on input.size_mb. So I will usually make both mem_mb and lsf_queue dependent on input.size_mb. But I guess it might be worth thinking about making stuff defined under resources: available again for other resources: settings -- I would just think that this will probably complicate parsing resources considerably...

@dlaehnemann wouldn't is be a nice feature to be able to point --workflow-profile to a specific file, too? Then we could collect profile templates in repos reading something like config_<cluster site>_<cluster name>_<date/version>.yaml. And thereby save re-inventing the wheel a bit.

But that is already pretty much what --workflow-profile does, right? It points to a directory containing a config.yaml. So we could simply have a repository with lots of subdirectories for profiles like you suggest. I am actually doing something similar internally, already. I just have to finally put it under version control, instead of just keeping it in the internal Nextcloud for (slightly easier) accessibility and access control...

And as mentioned above, and judging from our discussion (and my personal experience, as well): we really need to improve the Snakemake documentation on dynamic resource allocation!

cmeesters commented 5 months ago

@dlaehnemann yep, except that it calls for nested directories with specific names (which is fine and probably better than cluttering files in one directory) - I was just thinking in the wrong line, probably would have faced that issue, if not totally overworked already, sooner.

Hm, that

we really need to improve the Snakemake documentation

should it be part of the global documentation rather than the executor doc? I am currently working on an update to the executor doc. Ultimately, going for a major doc update in the central docs, calls for an coordinated effort.

dlaehnemann commented 5 months ago

Most of this belongs in the global docs, only executor-specific stuff (like how you define queues et. al) should go into the executor docs, I'd say.

sreichl commented 2 months ago

Hi, thanks again for the executor plugin.

I would love to have all variables from rules e.g., especially resources as callable for usage in dynamic resource allocation.

Thanks for your consideration & Cheers, Stephan

sreichl commented 2 months ago

@dlaehnemann, maybe I misunderstand, but I am using default profile configs in each of my workflows, but when I load them as module and run snakemake they are not used or even found (only the global profile). Can you help/explain? Thanks a lot!

profiles/default/config.yaml in the workflow that you are running (also works if the workflow is deployed via a module import). This will keep all settings restricted to that workflow instance.