search

snakemake / snakemake-executor-plugin-slurm

A Snakemake executor plugin for submitting jobs to a SLURM cluster
MIT License
18 stars 19 forks source link

fix: add --parsable to sbatch call for a more robust output parsing #125

Closed nigiord closed 3 months ago

nigiord commented 3 months ago

Following discussion in https://github.com/snakemake/snakemake-executor-plugin-slurm/issues/121#issuecomment-2270905243 , this implementation seems more robust than match a word with only numbers (which could break in future versions of slurm, or if a cluster name is made of only numbers).

cmeesters commented 3 months ago

Thank you for your contribution! I will merge this (after fixing the linter issue) - but a new release has to wait until some more contribs are merged. This contrib does not change behaviour, after all. It may wait a day or two.

nigiord commented 3 months ago

Sorry for the linter issue, I fixed it. Of course the current implementation works fine so it can wait for the next release :) . Thank you for time!

cmeesters commented 3 months ago

no need to apologize - thank you for your contribution once more!

(now, after the holidays, I am still pretty busy, but will work on improving the code once more)