search

snakemake / snakemake-executor-plugin-slurm

A Snakemake executor plugin for submitting jobs to a SLURM cluster
MIT License
9 stars 13 forks source link

Missing period or newline in status message when a SLURM job returns a failed status #82

Closed xapple closed 1 month ago

xapple commented 2 months ago

Currently this is what is printed when a job doesn't work for whatever reason:

[Fri May  3 22:06:31 2024]
Error in rule download:
    message: SLURM-job '704' failed, SLURM status is: 'FAILED'For further error details see the cluster/cloud log and the log files of the involved rule(s).
    jobid: 2
    output: /home/█████████/██████/██████/samples/██████/raw/run.sra
    log: /home/█████████/██████/.snakemake/slurm_logs/rule_download/██████/704.log (check log file(s) for error details)
    external_jobid: 704

As you can see there should be a period or newline here: "... 'FAILED'For further..."

I think it's this line of code:

https://github.com/snakemake/snakemake-executor-plugin-slurm/blob/912df8380b00742d256f42db8e7ab20d3836715b/snakemake_executor_plugin_slurm/__init__.py#L292C1-L293C1

cmeesters commented 2 months ago

Thank you for spotting this! It totally never hit my eye.

Fixed in PR #87