Package is missing dependencies in `pyproject.toml`

snakemake / snakemake-storage-plugin-gcs

A Snakemake storage plugin for Google Cloud Storage

MIT License

4 stars 5 forks source link

Package is missing dependencies in `pyproject.toml` #19

Closed w8jcik closed 4 months ago

w8jcik commented 7 months ago

snakemake-interface-common
snakemake-interface-storage-plugins

vsoch commented 7 months ago

@w8jcik this plugin isn't properly working yet, and I'm not familiar enough with the refactored interface to work on it, so any contribution you might make would be appreciated!

w8jcik commented 7 months ago

I believe that this is missing from pyproject.toml

[tool.poetry.dependencies]
...
+ snakemake-interface-common = "^1.14.2"
+ snakemake-interface-storage-plugins = "^3.0.0"

Although I don't know the required version of snakemake-interface-common.

Both packages are imported here https://github.com/snakemake/snakemake-storage-plugin-gcs/blob/main/snakemake_storage_plugin_gcs/__init__.py#L3

vsoch commented 7 months ago

Could you open a pull request?

w8jcik commented 7 months ago

I am not a user of Google Cloud Storage, I was just packaging Snakemake plugins for some package manager.

But maybe work of @jairav mentioned above solves this issue.

jairav commented 7 months ago

I have created a PR.