snakemake / snakemake-storage-plugin-gcs

A Snakemake storage plugin for Google Cloud Storage
MIT License
4 stars 5 forks source link

rename to -plugin-gs? #37

Closed vsoch closed 5 months ago

vsoch commented 5 months ago

@johanneskoester there is a bit of confusion about if the plugin is gs or gcs - that of course advises the prefix. If it is gs should we rename to that?

johanneskoester commented 5 months ago

It is gcs. I think that is the more official abbreviation of google cloud storage, therefore I changed the name.

johanneskoester commented 5 months ago

Closing, feel free to open or email me if I am missing something.

johanneskoester commented 5 months ago

Ah, now I see, there was still expected the old gs:// scheme in the query. My fault. I made a PR with a corresponding breaking change. Hopefully this is still early enough so that not too many people will be upset by such a breaking change.

39

vsoch commented 5 months ago

See https://github.com/snakemake/snakemake-executor-plugin-googlebatch/pull/50: still having trouble with default snakemake flags and plugins installed.