Closed Hugovdberg closed 1 day ago
@Hugovdberg thank you very much for tackling the issue. Would it be possible to merge this soon?
@FabianHofmann I'm afraid I can't merge the issue as I don't have permissions to do so on this repository. Maybe @johanneskoester can review my suggestion and approve the necessary checks before it can be merged.
The update introduces a new optional attribute supports_head
to the StorageProviderSettings
class, indicating if the storage provider can handle HTTP HEAD requests. The default value is set to True
. The httpr
method is modified to utilize requests.head
based on this attribute, enhancing HTTP request handling flexibility for storage providers.
Files | Change Summary |
---|---|
snakemake_storage_plugin_http/__init__.py |
Added supports_head: Optional[bool] to StorageProviderSettings , defaulting to True , and modified the httpr method to conditionally use requests.head . |
Objective | Addressed | Explanation |
---|---|---|
MissingInputException for Valid Downloadable URL (#21) | ❓ | The changes do not directly address the error reported. It is unclear if the new supports_head functionality resolves the issue with the specific URL. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Provides an option to disable the use of the HTTP HEAD verb for servers that don't allow that. Fixes #21
Summary by CodeRabbit