snakeztc / NeuralDialog-CVAE

Tensorflow Implementation of Knowledge-Guided CVAE for dialog generation ACL 2017. It is released by Tiancheng Zhao (Tony) from Dialog Research Center, LTI, CMU
https://www.cs.cmu.edu/~tianchez/
Apache License 2.0
309 stars 85 forks source link

About printing dialog act in test batch. #15

Closed sjkoo1989 closed 4 years ago

sjkoo1989 commented 4 years ago

https://github.com/snakeztc/NeuralDialog-CVAE/blob/6376dbeb8a9d052f671cf23ac2ccda175ab27687/models/cvae.py#L535

Dear Dr. Zhao. I'm Sangjun Koo from POSTECH (You may have heard of POSTECH from Dr. Kyusong Lee, one of my former advisor.)

Thanks for releasing your code for further research. Would you mind me asking some question about your code?

In reimplementing your code into PyTorch, I found that some anomaly which could be a bug(although it is not serious). The line should be np.argmax(sample_das[r_id], axis=1)[bid] instead of np.argmax(sample_das[r_id], axis=1)[0] since this may cause to print only the first predicted DA element in the batch.

Any comments would be welcome.