This pull request fixes the view implemented for admins inputting new currency conversions. The from_currency is now based on the currency of a conference's ticket and to_currency is based on a drop down list of a hard coded list from the currency_conversion model. Also fixes issues with migrating from submission instructions to submission_template.
Who authored this PR?
@tiffanylamm
How should this PR be tested?
There are written tests to test the feature and it's flow as well as edge cases. There is also validation testing for user input. There are added tests for correct erroring for cases like when a conference doesn't have any tickets.
Are there any complications to deploying this?
No.
Checklist:
[x] Has this been deployed to a staging environment or reviewed by a customer?
[x] Tag someone for code review (either a coach / team member)
[ ] I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay)
Pivotal Tracker Link
What this PR does:
This pull request fixes the view implemented for admins inputting new currency conversions. The from_currency is now based on the currency of a conference's ticket and to_currency is based on a drop down list of a hard coded list from the currency_conversion model. Also fixes issues with migrating from submission instructions to submission_template.
Who authored this PR?
@tiffanylamm
How should this PR be tested?
There are written tests to test the feature and it's flow as well as edge cases. There is also validation testing for user input. There are added tests for correct erroring for cases like when a conference doesn't have any tickets.
Are there any complications to deploying this?
No.
Checklist: