Closed Edge7481 closed 6 months ago
@Edge7481
Oh, now this one has some merge conflicts. Does the ENV['SHOW_CURRENCY_SELECTOR']
config need to exist anymore? It seems like actually it can be removed.
huh when i tried to resolve the merge conflicts on github's online editor it automatically synced my dev branch with snap-cloud/main.
Note: This PR depends on PRs up to #368
Pivotal Tracker Link
What this PR does:
Unfortunately quite a large PR that completes the payment process. Ideally I could've split the db migrations and frontend items into separate PRs, but the migration requires changing the parameters for a lot of tests.
Include screenshots, videos, etc.
Who authored this PR?
me
How should this PR be tested?
Added several tests in payment and ticket_purchase models that validate the existence of currency.
It's kind of difficult to know how I can improving testing. I think for now the most important part is ensuring that payments are stored correct. The features test case ensures that the ticket_purchase records the correct amount and currency, but it may need more comprehensive testing. Also, may need testing for currency conversion functionality in the event that an existing currency was used to complete a transaction, but that currency is later removed. Will need to check for interaction with the db
Are there any complications to deploying this?
Will need a migration
Checklist: