search

snap-research / NeROIC

Other
937 stars 121 forks source link

Inconsistent hyperparameters reported in the paper and configuration files #20

Closed jingsenzhu closed 2 years ago

jingsenzhu commented 2 years ago

I found some hyperparameters in configuration files inconsistent with those reported in the original paper. For example, lambda_tr is 1 in config while 0.01 in the original paper. Which one should I refer to?

zfkuang commented 2 years ago

Since our two stages use different blending methods for the transient color, the lambda_tr is also set to different values. In our paper, lambda_tr is set to 0.01 for the geometry stage and to 1 for the rendering stage, which is consistent with our configs. If there's any other differences between the configs and the paper, please let us know (and try config first).