A possible mistake in computing TPS - Githubissues

snap-research / articulated-animation

Code for Motion Representations for Articulated Animation paper

https://snap-research.github.io/articulated-animation/

Other

1.23k stars 349 forks source link

A possible mistake in computing TPS #50

Open XiaLiPKU opened 2 years ago

XiaLiPKU commented 2 years ago

Hi, Aliaksandr. Your code is really nice. However, I find a small mistake here from L118 to L120: https://github.com/snap-research/articulated-animation/blob/db2c2135273f601a370e2b62754f9bb56cfd25d5/modules/model.py#L118 https://github.com/snap-research/articulated-animation/blob/db2c2135273f601a370e2b62754f9bb56cfd25d5/modules/model.py#L120

Shouldn't it be result = (distances ** 2).sum(-1)? With which change, the code will be more consistent with: https://github.com/tomasjakab/imm/blob/0fee6b24466a5657d66099694f98036c3279b245/imm/utils/tps_sampler.py#L138

XiaLiPKU commented 2 years ago

By the way, this also happens in other two of your repos: https://github.com/AliaksandrSiarohin/first-order-model/blob/ca49071ce60051200f58f03a0e4e65e675a54e27/modules/model.py#L105 https://github.com/AliaksandrSiarohin/motion-cosegmentation/blob/571e26f04b8c40c5454a158b4b570e4ba034c856/modules/model.py#L96