snap-stanford / ogb

Benchmark datasets, data loaders, and evaluators for graph machine learning
https://ogb.stanford.edu
MIT License
1.89k stars 397 forks source link

Wrong number of parameters in ogbn-arxiv GCN submission? #239

Closed zjost closed 3 years ago

zjost commented 3 years ago

The GCN submission for ogbn-arxiv reports 142,888 parameters on the leader-board. Looking at the code and default settings, it seems to use the following architecture:

This architecture gives a total number of parms of 110,120, which is 32,768 fewer than that reported on the leader-board. It's probably not a coincidence that this number is equal to the input*hidden dimensions. Is there some other projection layer coming into play, is the leader-board mistaken, or something else?

weihua916 commented 3 years ago

Hi! You are right, that was a mistake. When I run sum(p.numel() for p in model.parameters()) I indeed got 110,120. I have updated the parameter count.