Binary attribute for ogbg-molhiv returns false

snap-stanford / ogb

Benchmark datasets, data loaders, and evaluators for graph machine learning

https://ogb.stanford.edu

MIT License

1.93k stars 397 forks source link

Binary attribute for ogbg-molhiv returns false #249

Closed henrykenlay closed 3 years ago

henrykenlay commented 3 years ago

The below snippet gives False, but ogbg-molhiv labels are binary. Unless I'm misunderstanding what the binary attribute represents (I can't find it in the docs) this should evaluate to True? I am using ogb version 1.3.1

from ogb.graphproppred import PygGraphPropPredDataset

dataset = PygGraphPropPredDataset(name='ogbg-molhiv', root='dataset')
print(dataset.binary)

weihua916 commented 3 years ago

Binary attribute just means whether the data file is provided as csv file or numpy’s binary file. For molecule datasets, we provide them as csv file; hence, dataset.binary is False

henrykenlay commented 3 years ago

I see 😳. Is there a page that documents these kinds of things (classes and their attributes etc.)? Is this something that the OGB team is working on?

weihua916 commented 3 years ago

The best documentation is probably our example code. Those details (e.g., file saving format) are unimportant to the users; hence, we do not provide such documentations.