search

snap-stanford / ogb

Benchmark datasets, data loaders, and evaluators for graph machine learning
https://ogb.stanford.edu
MIT License
1.89k stars 397 forks source link

biokg bug_fix #288

Closed Zahra-Bakhtiari closed 2 years ago

Zahra-Bakhtiari commented 2 years ago

biokg_bug_fix:

the run.py file in biokg has a bug when it is running on linux which essentially stops the model from reporting the train/valid/test results gradually at each step which is confusing for users

Below PR is my fix for this issue https://github.com/Zahra-Bakhtiari/biokg_bug_fix/pull/1/files

weihua916 commented 2 years ago

Thanks for PR! Why not just pass --print_on_screen?

Zahra-Bakhtiari commented 2 years ago

Maybe I did not explain it fully. I trained RotatE and pRotatE on ogbl-biokg model on AWS. It took more than 12 hours and during the first try nothing was showing up on the screen so I had no idea what would be the state of the model and when I can turn off EC2 resources, this fix resolved the issue

weihua916 commented 2 years ago

Yes, I understand. If you want something on the screen, you just add the turn on the argument --print_on_screen.