snapauthapp / sdk-swift

Swift SDK for SnapAuth (all Apple platforms)
https://www.snapauth.app
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Remove erroneous assertion #34

Closed Firehed closed 2 months ago

Firehed commented 2 months ago

31 adjusted the assertion during sending errors back, and reintroduced the data race from canceling the autofill request due to starting a modal one (explicitly returning a failure to the continuation, clearing it out, and canceling the authController - which went back to sendError)

This removes the assertion, since it was logically unsound, not to mention unhelpful. I've done another bunch of manual testing in a sample app and can no longer reproduce the issue. I'm not sure how to cover this in automated tests to prevent another regression, but I'll file a ticket in case someone finds a way.