search

snapcore / core-initrd

initrd implementation in ubuntu core
https://ubuntu.com/core/docs
GNU General Public License v3.0
9 stars 27 forks source link

ubuntu-core-initramfs: copy missing modules.builtin.modinfo #228

Closed valentindavid closed 7 months ago

valentindavid commented 7 months ago

This file is needed by dracut-install when installing modules. So we should copy it.

alfonsosanchezbeato commented 7 months ago

This looks fine, but I wonder how was this affecting us? Were we not including all dependencies for a module in some case?

valentindavid commented 7 months ago

This looks fine, but I wonder how was this affecting us? Were we not including all dependencies for a module in some case?

I suppose when a modprobe of a builtin happen it fails instead of silently ignore it. But most modprobe are done from the kernel, so they do not happen for builtin. And the others are from modules-load.d, which I think is empty now. And if not, it does not count as failure.