search

snapcore / pi-gadget

Universal pi (pi2,pi3,pi4,cm3,cm4 and future) gadget snap for Ubuntu Core and classic systems.
30 stars 60 forks source link

Remove reference to DESTDIR in gadget.yaml source content #105

Closed upils closed 6 months ago

upils commented 6 months ago

Based on the gadget snap documentation and other versions of gadget snap, the paths used in the content section should not suppose the gadget.yaml file is in the parent directory of the assets. This directory is given as another parameter to the tool handling the gadget (snapd, ubuntu-image, etc.). So we remove the reference to the DESTDIR since this directory will be the root dir given to the tool in most cases.

This is related to https://github.com/canonical/ubuntu-image/pull/175

upils commented 6 months ago

@waveform80 @sil2100 can you review? This change is very small but it might break something I am not aware of.

upils commented 6 months ago

Cool! Now let's just wait for the sync with launchpad and we will be able to retry spread tests of https://github.com/canonical/ubuntu-image/pull/165 to see if raspi ones pass.