search

snapcore / pi-gadget

Universal pi (pi2,pi3,pi4,cm3,cm4 and future) gadget snap for Ubuntu Core and classic systems.
30 stars 60 forks source link

Simplify classic #114

Open waveform80 opened 2 weeks ago

waveform80 commented 2 weeks ago

The "classic" branch currently generates the boot config for the various releases. This is a good example of something that is "too clever to be maintainable" and needs replacing with something much simpler. This branch removes all the horridly complex generation of configs from the Makefile and replaces them with trivial copy operations. The config template snippets are removed and replaced with a series of directories, the contents of which have been directly extracted from the corresponding images.

This branch also removes the "core" target from the "Makefile"; this branch can't build core gadgets and shouldn't pretend it can, and finally adds some brief documentation of the new layout of the "configs" directory.

waveform80 commented 2 weeks ago

Open question: I've included the (now unsupported) interim releases in the "configs" directory not so that they can actually be generated, but more so one can track the evolution of the boot configuration over releases. However, it's arguable that these should just be excluded for further simplification.

Then again, we don't bother pruning unsupported branches from repos like lp:ubuntu-images so perhaps these should just stick around?