snapcore / pi-gadget

Universal pi (pi2,pi3,pi4,cm3,cm4 and future) gadget snap for Ubuntu Core and classic systems.
30 stars 60 forks source link

Merged core18 arm64 gadget #24

Closed waveform80 closed 4 years ago

waveform80 commented 4 years ago

The 18-arm64 branch is the basis for the new merged core/classic gadget. That is to say, that the other branches (18-armhf and classic) are to be trivial modifications from this branch. Hence, this PR should be reviewed first.

I did consider making the new classic branch the "base" and deriving from there, but for the time being it's easier to derive from core as it mostly involves removing stuff (like psplash) rather than derive from classic which would entail adding stuff (like psplash).

This PR appears complex but the way to view it is as a merge of 18-armhf into 18-arm64 (which was the first step, in the second-to-last commit after which the branches were identical), followed by modifications to make the branch "universal" (the last commit), so if you're happy with everything in the 18-armhf branch everything up to the second-to-last commit should be fine and it's only the last commit that requires review.