search

snapcore / pi-gadget

Universal pi (pi2,pi3,pi4,cm3,cm4 and future) gadget snap for Ubuntu Core and classic systems.
30 stars 60 forks source link

improve readme to explain building in a container #72

Closed stulluk closed 3 years ago

anonymouse64 commented 3 years ago

Have you tried letting snapcraft manage the LXD container for you via SNAPCRAFT_BUILD_ENVIRONMENT=lxd snapcraft --enable-experimental-package-repositories ? That should work, it's how we build it in Travis CI and how other developers built it locally too

stulluk commented 3 years ago

Have you tried letting snapcraft manage the LXD container for you via SNAPCRAFT_BUILD_ENVIRONMENT=lxd snapcraft --enable-experimental-package-repositories ? That should work, it's how we build it in Travis CI and how other developers built it locally too

Thank you ! This simplified explanation a lot. Do you have any other suggestions to improve ?

anonymouse64 commented 3 years ago

What you have is reasonable, but if you want to have more eyes on it, I would recommend @degville to also take a look here

degville commented 3 years ago

I've incorporated @stulluk's suggestions, along with a few more fixes, into #75.

stulluk commented 3 years ago

I've incorporated @stulluk's suggestions, along with a few more fixes, into #75.

I believe it is better to close this PR, how do you think ?