search

snapcore / spread

Spread - Convenient full-system test (task) distribution
GNU General Public License v3.0
99 stars 58 forks source link

fix: runner: ignore unknown file types and sockets (fixes #176) #180

Closed thp-canonical closed 5 months ago

thp-canonical commented 6 months ago

Do not pack unknown file types + UNIX domain sockets when creating the tarball.

See #176 for a detailed description of the problem.

ZeyadYasser commented 5 months ago

I replied in the issue https://github.com/snapcore/spread/issues/176#issuecomment-2009041848, I think this approach could accidentally suppress unexpected behaviors that are hard to debug. Would the exclude pattern suggested in the issue be a suitable alternative?

thp-canonical commented 5 months ago

I replied in the issue #176 (comment), I think this approach could accidentally suppress unexpected behaviors that are hard to debug. Would the exclude pattern suggested in the issue be a suitable alternative?

Agreed, I'll close this PR for now but keep the branch open in case we want to do something like this in the future. Let's continue the discussion in #176.