snapcrafters / alacritty

A community-maintained package to easily install Alacritty on Linux
MIT License
9 stars 12 forks source link

Fix mouse cursor theme issue #29

Closed pedro-avalos closed 4 months ago

pedro-avalos commented 4 months ago

This should address #21.

Unless I'm missing something, this environment variable (XCURSOR_PATH) is set by the desktop-launch wrapper that comes from the snapcraft-desktop-helpers set of utilities in order to match the base theme on the workstation; unsetting this variable here undoes that work, and it leads to Alacritty using a white mouse cursor instead of falling back to the default cursor that would be expected (Yaru in most cases).

I think that if someone wanted to modify this behavior (I noticed that this line was originally added to "respect user customization"), they should address it upstream in snapcraft-desktop-helpers, where XCURSOR_PATH is being modified without appending/preppending, but not in Alacritty.

I've tested these changes locally and they seems to fix the cursor issue. Let me know what you think, or if I missed something in this!

aftuw commented 3 months ago

This change breaks the cursor on my system (Kubuntu), because the XCURSOR_PATH is set to the invalid value /snap/alacritty/135/usr/share/icons. The result is that the Alacritty window then uses the default fallback X11 cursor theme.